Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jstzd): add bootstrap accounts to ProtocolParameterBuilder #578

Open
wants to merge 1 commit into
base: huanchengchang-jstz-149
Choose a base branch
from

Conversation

huancheng-trili
Copy link
Collaborator

@huancheng-trili huancheng-trili commented Sep 27, 2024

Context

Part of JSTZ-149.

JSTZ-149

Description

Adds bootstrap accounts to the base protocol parameter set.

Manually testing the PR

  • Generated one parameter file with default sandbox bootstrap accounts and tested the file in a sandbox.
  • Unit test: added test cases.
  • Integration test: waiting for other octez-client PRs

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 97.59036% with 2 lines in your changes missing coverage. Please review.

Project coverage is 37.89%. Comparing base (6a9bd15) to head (622cf9e).

Files with missing lines Patch % Lines
crates/jstzd/src/protocol/bootstrap.rs 96.00% 0 Missing and 2 partials ⚠️
Files with missing lines Coverage Δ
crates/jstzd/src/protocol/mod.rs 84.78% <100.00%> (+4.40%) ⬆️
crates/jstzd/src/protocol/bootstrap.rs 96.00% <96.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a9bd15...622cf9e. Read the comment docs.

@huancheng-trili huancheng-trili marked this pull request as ready for review October 3, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant